MetaMask / MetaMask/metamask-mobile

Allow removing ETH-named tokens

Open
#2,553 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

Consider the below image. The asset is "ETH", and we're not showing the three-dot menu in the upper-right corner to enable hiding the asset. All good? No! It's not native ETH, but a token named ETH. I'm gonna bet our logic for hiding/showing the menu is too naive to handle this case. We should fix it.

The user that reported this also says that resetting their account does not hide or remove this asset.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported asset state from the screenshot and tracing the logic that decides whether the three-dot menu is shown. Check the reset-account flow as well; done means a token named ETH can be hidden and is removed or hidden after account reset without affecting native ETH.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
blockchain, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.