MetaMask / MetaMask/metamask-mobile
Extend the shared MetaMask ESLint config
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
Mobile should extend:
- `@metamask/eslint-config`, for all files
- `@metamask/eslint-config-jest`, for tests
As discussed, rules can be disabled in the local ESLint config to make the overhead of migrating smaller.
For related work, see: https://github.com/MetaMask/eslint-config/issues/170, https://github.com/MetaMask/eslint-config/issues/171
This is a major change for dev experience (has no impact on users). After this change takes place, the engineers will have to code in a different way (before / after moment)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the local ESLint configuration and reviewing how it applies to all files and tests. Compare it with @metamask/eslint-config and @metamask/eslint-config-jest, and consult related issues 170 and 171; done means Mobile extends both shared configurations while any necessary local rule exceptions are documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, typescript
- Domain
- developer-experience, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100