MetaMask / MetaMask/metamask-mobile
[Bug]: (Snaps) Connect bottom sheet still pops up after connecting to dapp
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### Describe the bug
there seems to be a bug in the snaps flow, specifically raised in this test: `e2e/specs/snaps/test-snap-management.spec.ts `
The flow is:
go to browser and open snaps example dapp
connect to snaps dapp
tap connect button
approve permission
tap ok
After going through the above flow, the connect bottomsheet reappears.
### Expected behavior
Bottom sheet should not reappear after connected to dapp.
### Screenshots/Recordings
### Steps to reproduce
Change your `METAMASK_BUILD_TYPE` to 'flask'
run the snaps management test: `yarn test:e2e:ios:debug:run e2e/specs/snaps/test-snap-management.spec.ts`
Notice the bug
### Error messages or log output
```shell
```
### Where was this bug found?
Internal release testing
### Version
7.62.0 (main)
### Build number
3418
### Build type
None
### Device
iOS
### Operating system
iOS
### Additional context
_No response_
### Severity
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running e2e/specs/snaps/test-snap-management.spec.ts with METAMASK_BUILD_TYPE set to flask using the documented iOS debug command. Trace the connect, permission approval, and OK steps to identify why the connect bottom sheet appears again; done means the sheet stays dismissed after connecting to the Snaps example dapp.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100