MetaMask / MetaMask/metamask-mobile

[Bug]: When Lending Deposit Approval fails, users are not shown a notification about the failed transaction,

Open
#24,000 0 comments 0 reactions 0 assignees View on GitHub
regression-RC-7.61.0 Sev2-normal team-earn type-bug
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### Describe the bug

When `Lending Deposit Approval` fails, users are not shown a notification about the failed transaction. Instead, they are taken back to the confirming transactions step. Unless the tx is cancelled users stuck on approving and confirming transactions.

### Expected behavior

Clear indication of the transaction failure.

### Screenshots/Recordings

https://github.com/user-attachments/assets/90794535-55cf-4146-8bea-d0fae26cde4e

### Steps to reproduce

1. Create Lending approval that will fail
2. Click `Approve / Confirm`
3. Notice repeated approval / confirmation request for the same transaction
4. Approval tx is marked as `Failed `in the Activity tab

### Error messages or log output

```shell

```

### Where was this bug found?

Internal release testing

### Version

7.61.0

### Build number

3284

### Build type

None

### Device

Samsung S24+

### Operating system

Android

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the Lending Deposit Approval failure on Android using the listed steps, then trace the approval and confirmation flow. No file or test is named in the issue, so locate the failure handling and Activity-tab status path first. Done means a failed approval shows a clear notification and does not send users back into repeated approval or confirmation requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
blockchain, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.