MetaMask / MetaMask/metamask-mobile
[Bug]: Swap network fees not always accurate
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### Describe the bug
Issues
- effective gas fees are used to gate tx submission (these are lower than the actual required gas amount)
- when gas is included in the quote, the network fee estimates are shown instead of the estimates provided by the backend
### Expected behavior
The totalNetworkFee should gate tx submission. `includedTxFees` should be shown when submitting a gasIncluded trade
### Screenshots/Recordings
_No response_
### Steps to reproduce
1. Request EVM quotes
### Error messages or log output
```shell
```
### Where was this bug found?
Live version (from official store)
### Version
7.60.4
### Build number
3255
### Build type
None
### Device
iPhone 15
### Operating system
iOS
### Additional context
_No response_
### Severity
_No response_
Contributor guide
Research direction
Start by tracing the EVM quote request and gasIncluded trade submission flow in the mobile app. Verify that totalNetworkFee gates transaction submission and that includedTxFees is displayed for gasIncluded trades; reproduce with an EVM quote to confirm the corrected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- blockchain, react-native, typescript
- Domain
- blockchain, mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100