MetaMask / MetaMask/metamask-mobile

Increase developer velocity for deep link building

Open
#23,500 1 comment 0 reactions 1 assignee Claimed by @smilingkylan View on GitHub
team-mobile-platform
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

Take steps to reduce the numbers of steps to allow the app to create deep links. This feature will reduce the number of steps from x to x steps.

- [ ] `handlers` directory
- No need for legacy vs V2, remove V2 code for now
- is `connectWithWC` a handler and if so, rename to match other handlers
- [ ] Remove `registry`, `router`, and `normalization`
- If logic needs to be retained, make them utility functions and move them into utils directory
- [ ] `types` directory
- Unify into `types.ts` file
- [ ] Top level floating files
- Move `parseDeeplink` into `utils` directory
- Move `handleDeeplink` into `handlers` directory
- [ ] `SharedDeeplinkManager` and `DeeplinkManager` file
- Remove this layer and keep `DeeplinkManager.ts` file
- Export both class and shared instance from `DeeplinkManager`

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [x] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.