MetaMask / MetaMask/metamask-mobile
[Bug]: Confirmations - `Estimate Balance Changes` is displayed while having the feature disabled from settings in the ERC20 Approve
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
Describe the bug
Estimate Balance Changes is displayed while having the feature disabled from settings in the ERC20 Approve.
This has an additional issue which is, the Spending cap can only be editted from the Estimate Balance Change section, meaning, if that section is removed (as expected if the feature is disabled) then we won't be able to edit the spending cap
Expected behavior
- Decouple Estimate Balance changes from Spending Cap edit
- Dont' display Estiamte Balance changes if the feature is disabled from settings
Screenshots/Recordings
https://github.com/user-attachments/assets/e3bfd05b-1c57-4c13-8d0b-d544cb91212b
Steps to reproduce
- Go to Privacy Settings
- Disable Estimate Balance Changes feature
- Go to the test dapp
- Deploy an ERC20 token
- Trigger ERC20 approval
- See Estimate Balance Changes section
Error messages or log output
Detection stage
During release testing
Version
7.58.0
Build type
None
Device
Pixel 6
Operating system
Android
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the mobile confirmation flow reached during an ERC20 approval and trace how the Privacy Settings value for Estimate Balance Changes controls its display. Verify that disabling the feature hides that section while the spending-cap edit remains available independently; reproduce using the listed test-dapp steps and confirm both behaviors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100