MetaMask / MetaMask/metamask-mobile
JazzIcons and BlockieIcons with Turbo Native Modules
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### What is this about?
This issues have the intention of converting the jazz icons and the blockie icons to from JS code to turbo native modules to increase it's performance
https://github.com/MetaMask/metamask-mobile/blob/5db2f60c7216e9fcd32896ad56fc51464e3c905a/app/util/blockies.js#L1
https://github.com/stanislaw-glogowski/react-native-jazzicon#readme
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Research direction
Start with app/util/blockies.js and the linked react-native-jazzicon README to understand the existing BlockieIcons and JazzIcons implementations. Define the Turbo Native Modules approach and its scope before changing the JavaScript implementations; done means both icon types are converted and their performance improves without a stated acceptance test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native, typescript
- Domain
- mobile, performance
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100