MetaMask / MetaMask/metamask-mobile
Incoming token transfer e2e failure
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
**What is this about?**
A pull request was merged into the main branch, impacting the CheckIfVisible assertion. This change allowed the tests to pass, enabling the previous PR to be merged.
Currently, there is an open and soon-to-be-merged PR https://github.com/MetaMask/metamask-mobile/pull/15347 aimed at fixing the CheckIfVisible assertion, which will, in turn, reveal the e2e failure again.
With that said, the `displays incoming token transfer` it block in https://github.com/MetaMask/metamask-mobile/blob/main/e2e/specs/wallet/incoming-transactions.spec.js is failing consistently.
You can see the test failure [here](https://app.bitrise.io/build/f8186728-d80a-4f4d-b2a3-6f584c974586)
Keep in mind the failure occurs on
ttps://github.com/MetaMask/metamask-mobile/pull/15347
**Stakeholder review needed before the work gets merged**
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
Contributor guide
Research direction
Start with e2e/specs/wallet/incoming-transactions.spec.js and reproduce the `displays incoming token transfer` failure on pull request 15347. Read the CheckIfVisible assertion changes and compare the Bitrise failure; done means the incoming token transfer test passes consistently after that assertion fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile-dev, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100