MetaMask / MetaMask/metamask-mobile

Remove unused parameter in `getCaip25PermissionFromLegacyPermissions`

Open
#15,520 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

https://github.com/MetaMask/metamask-mobile/pull/15477 makes the `origin` parameter in `getCaip25PermissionFromLegacyPermissions` unnecessary. We should remove it and refactor its usage.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Locate getCaip25PermissionFromLegacyPermissions and inspect the changes introduced by pull request 15477. Remove the unnecessary origin parameter, update its usages, and run the relevant existing checks to confirm permission handling still works without it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.