MetaMask / MetaMask/metamask-mobile
[Bug]: Incorrect message when disabling Profile Sync, as Notifications is no longer dependent on Profile Sync toggle
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### Describe the bug
When disabling `Profile sync` from settings, a message appears that `Notifications` won't be received anymore.
Since `Notifications` is no longer dependent on `Profile Sync` toggle, then the message should be updated
Currently: Disabling Profile sync does not disable Notifications
Same issue as [extension](https://github.com/MetaMask/metamask-extension/issues/30968)
### Expected behavior
Correct message to appear when disabling profile sync
### Screenshots/Recordings
https://github.com/user-attachments/assets/9a508892-fa6f-458e-a040-4bcfc35d8358
### Steps to reproduce
1. Go to Settings Security & privacy
2. Turn OFF Profile Sync
3. Notice message regarding disabling notifications
4. Click on the 3 dots and Notifications or go to Settings Notifications
5. Notice Notifications are still enabled
### Error messages or log output
```shell
```
### Detection stage
During release testing
### Version
7.45.0
### Build type
None
### Device
iPhone15, Pixel 6 Pro
### Operating system
iOS, Android
### Additional context
_No response_
### Severity
_No response_
Contributor guide
Research direction
Reproduce the issue through Settings > Security & privacy by turning off Profile Sync, then search the mobile source for the current message shown in the report. Done means the Profile Sync warning no longer says Notifications will be disabled, while Notifications remain enabled when checked from the notification settings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100