MetaMask / MetaMask/metamask-mobile
Update skeleton component
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
## **Description**
Move the Skeleton component from `app/component-library/components/Skeleton` to a temporary components folder while it undergoes review and refinement.
- Update `hideChildren` to `isChildrenHidden`
## **Technical Details**
- Move the following files to `app/component-library/components-temp/Skeleton/`:
- Skeleton.stories.tsx
- README.md
- Skeleton.tsx
- Skeleton.types.ts
- Skeleton.test.tsx
- Skeleton.styles.ts
- __snapshots__/
- index.ts
- Update any existing imports in the codebase to reference the new location
- Ensure all tests pass after the move
- Update storybook configuration to reflect new component location
## **Threat Modeling Framework**
- What are we working on?
- Moving a component to a temporary location for review and refinement
- No functional changes to the component itself
- What can go wrong?
- Missing import updates could break existing usage
- Storybook configuration might not reflect new location
- Tests might fail due to path changes
- What are we going to do about it?
- Use IDE search to find all component imports
- Update storybook configuration
- Run full test suite after move
- Manual verification of component in storybook
- Did we do a good job?
- All tests pass
- Storybook shows component correctly
- No runtime errors in app
- No broken imports
## **Acceptance Criteria**
- [ ] Component and all related files moved to `app/component-library/components-temp/Skeleton/`
- [ ] All imports updated to reference new location
- [ ] All tests passing
- [ ] Storybook showing component correctly
- [ ] No console errors
- [ ] Documentation updated to reflect new location
## **Stakeholder Review**
- [x] Engineering (needed in most cases)
## **References**
- Current location: `app/component-library/components/Skeleton`
- New location: `app/component-library/components-temp/Skeleton`
- Component files:
- Skeleton.stories.tsx
- README.md
- Skeleton.tsx
- Skeleton.types.ts
- Skeleton.test.tsx
- Skeleton.styles.ts
- __snapshots__/
- index.ts
Contributor guide
Research direction
Start with app/component-library/components/Skeleton and inspect the listed component, test, snapshot, story, styles, types, README, and index files. Search the repository for imports and Storybook references to Skeleton, then move the files to app/component-library/components-temp/Skeleton and update those references. Done means tests pass, Storybook renders the component, documentation reflects the new location, and there are no broken imports or console errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- documentation, frontend, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100