MetaMask / MetaMask/metamask-mobile

Fitness function enforcing migrations for new/updated controllers

Open
#13,063 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

Add a fitness function when a new controller is introduced and require a migration. This function would detect a new controller being added into the code repository and check for a migration change in the same PR. It would fail and allow the user to by-pass with a label or comment.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [x] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by locating existing fitness functions and the conventions for detecting controllers, migrations, and PR labels or comments; done means a new or updated controller requires a migration change while supporting the described bypass.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
ci-cd, devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.