MetaMask / MetaMask/metamask-mobile

Move shortenString helper file to be used as a general helper

Open
#13,016 0 comments 1 reaction 0 assignees View on GitHub
2026-Q1---Confirmations-cleanup external-contributor INVALID-ISSUE-TEMPLATE team-confirmations
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

**What is this about?**

Currently, shortenString helper lives in `app/util/notifications/methods/common.ts`. However, there are no use-cases for shortenString until recent redesign confirmation PRs.

This issue is to move shortenString to a new filepath to be used at a higher scope

**Stakeholder review needed before the work gets merged**

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

Contributor guide

Open the contributing guide

Research direction

Start by reading app/util/notifications/methods/common.ts and tracing shortenString references, including the redesign confirmation PRs mentioned in the issue. Determine the appropriate higher-scope location before moving the helper, then update its consumers and verify the existing checks pass. Done means the helper is available from its new path without breaking current uses.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.