MetaMask / MetaMask/metamask-mobile
Create storybook page for ButtonPill and update unit tests
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
**What is this about?**
Create storybook page for ButtonPill component.
Update unit tests by replacing snapshot with logic based asserts
**Stakeholder review needed before the work gets merged**
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ButtonPill component and its existing unit tests, then identify the project's Storybook entry point for components. Run the current ButtonPill unit tests before changing them. Done means ButtonPill has a Storybook page and the snapshot is replaced with logic-based assertions that pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, storybook, typescript
- Domain
- frontend, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100