MetaMask / MetaMask/metamask-mobile
Reduce duplication of Popular networks within e2e
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### What is this about?
This task aims to reduce duplication by using the CustomNetworks.tsx list instead of duplicating it in networks.e2e.js. To achieve this, we need to update the network state in the fixture builder class to align with the CustomNetworks list.
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
All networks related e2e should pass
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Research direction
Compare the Popular networks list in CustomNetworks.tsx with networks.e2e.js, then inspect the fixture builder class that provides network state. Align the fixture state with CustomNetworks.tsx and run all network-related e2e tests; done means those tests pass without a duplicated network list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native, typescript
- Domain
- mobile-dev, testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100