MetaMask / MetaMask/metamask-mobile

[Feat]: Replace <Tooltip> instances with useTooltipModal and BottomModal with BottomSheet

Open
#12,656 2 comments 0 reactions 0 assignees View on GitHub
Confirmations external-contributor INVALID-ISSUE-TEMPLATE team-confirmations
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

**What is this about?**

BottomModal uses react-native-modal modal. This prevents us from making use of BottomSheet.
useTooltipModal renders a BottomSheet.

We want to replace instances with the useTooltipModal hook and with

Per the design request, we want to use useTooltipModal to render BottomSheets instead of new custom tooltips. See:
- `app/components/Views/confirmations/components/UI/InfoRow/InfoRow.tsx` →
- BottomModal instances

**Stakeholder review needed before the work gets merged**

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

Contributor guide

Open the contributing guide

Research direction

Start with app/components/Views/confirmations/components/UI/InfoRow/InfoRow.tsx and inspect its usage, then search the repository for other Tooltip and BottomModal instances. Trace the existing useTooltipModal and BottomSheet APIs before changing callers. Done means the identified instances use the new APIs and required stakeholder reviews are completed.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
frontend, mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.