MetaMask / MetaMask/metamask-mobile

Add quality gate that would block on increasing peer dependency warnings

Open
#12,576 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework-deprecated
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

Add quality gate that would block on increasing peer dependency warnings. If this is doable in yarn at the local dev point we should do it there.
AKA: We can switch to having the yarn warnings from warnings to errors around peer dependencies. Breaks on yarn install. There is a way to disable peer dependencies. -- Maybe this is possible with yarn plugin, we might have to roll our own solution here. Align this for both Mobile and Extension. Which ever path we go we should do the same for the other client.

Otherwise lets do this via CI.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [X] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the repository's Yarn configuration and CI workflows to determine whether peer-dependency warnings can be promoted to failures locally or in CI. Compare the available approach for Mobile with the requested equivalent for Extension, and define the warning threshold and acceptance checks before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
build-system, ci-cd, mobile
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.