MetaMask / MetaMask/metamask-mobile

chore: get rid of legacy events

Open
#11,568 0 comments 0 reactions 0 assignees View on GitHub
INVALID-ISSUE-TEMPLATE team-mobile-platform
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

Remove all legacy events in app/core/Analytics/MetaMetrics.events.ts and migrate them to new event format

### Scenario

_No response_

### Design

_No response_

### Technical Details

- remove or migrate events
- update code where they are used

### Threat Modelling Framework

_No response_

### Acceptance Criteria

- No remaining legacy events
- all calls updated
- unit tests pass

### Stakeholder review needed before the work gets merged

- [x] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

Contributor guide

Open the contributing guide

Research direction

Start with app/core/Analytics/MetaMetrics.events.ts, then search the repository for every use of the legacy events and inspect the surrounding call sites. Migrate or remove each event and update all calls; run the unit tests and confirm no legacy events remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
analytics
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.