MetaMask / MetaMask/metamask-mobile

[Network-controller-upgrade] Remove Feature Flag and Fix E2E Tests

Open
#11,233 0 comments 0 reactions 2 assignees Claimed by @cryptodev-2s View on GitHub
INVALID-ISSUE-TEMPLATE
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

This issue involves removing the feature flag `MM_NETWORK_UI_REDESIGN_ENABLED` that currently gates the UI changes and ensuring that all end-to-end (E2E) tests are updated and passing. The feature flag was initially introduced to control the rollout of the new UI changes. With the feature now stable, it is time to remove the flag and make the changes permanent.

**Tasks:**

**Remove Feature Flag:**
Identify all instances of the feature flag in the codebase.
Remove the feature flag checks and ensure that the new UI changes are always enabled.
Clean up any related code that is no longer necessary.

**Update E2E Tests:**
Review all existing E2E tests to ensure they are compatible with the new UI changes.
Update the tests to remove any dependencies on the feature flag.
Add new E2E tests if necessary to cover any new functionality introduced by the UI changes.

**Run and Fix E2E Tests:**
Run the full suite of E2E tests to identify any failing tests.
Fix any issues identified during the test run to ensure all tests pass.
Ensure that the tests cover all critical user flows and edge cases.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.