MetaMask / MetaMask/metamask-mobile

NetworkController upgrade from v19 to v20

Open
#11,040 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

The `NetworkController` is behind by two major versions and needs to be updated.
Upgrade from v19 to v21.
Additionally, there are several peer dependencies which will likely be best to be upgraded at the same time. Those are the following:

- `GasFeeController` is on 18 should be on 20
- `TransactionsController` v 35 should be v36

### Scenario

n/a

### Design

n/a

### Technical Details

n/a

### Threat Modeling Framework

n/a

### Acceptance Criteria

- `NetworkController` is on v21
- `GasFeeController` is on v20
- `TransactionsController` is on v36

### Stakeholder review needed before the work gets merged

- [X] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the NetworkController, GasFeeController, and TransactionsController version declarations in the repository's dependency or package configuration. Check how related controller versions are coordinated and run the existing automation tests. Done means NetworkController is v21, GasFeeController is v20, and TransactionsController is v36.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.