MetaMask / MetaMask/metamask-mobile
Conversion Javascript files to Typescript files in core directory
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### What is this about?
This epic includes all the javascript files that need to be converted to typescript files on the core directory by chunks of 5 files.
First: https://github.com/MetaMask/metamask-mobile/issues/10815
```
app/core/BackgroundBridge/BackgroundBridge.js
app/core/Permissions/specifications.js
app/core/RPCMethods/index.js
app/core/RPCMethods/wallet_addEthereumChain.js
app/core/RPCMethods/wallet_switchEthereumChain.js
```
Second: https://github.com/MetaMask/metamask-mobile/issues/10818
```
app/core/DrawerStatusTracker.js (can be deleted)
```
Third: https://github.com/MetaMask/metamask-mobile/issues/10816
```
app/core/WalletConnect/WalletConnect.js
app/core/ClipboardManager.js
app/core/EntryScriptWeb3.js
app/core/MobilePortStream.js
```
Forth: https://github.com/MetaMask/metamask-mobile/issues/10817
```
app/core/NotificationManager.js
app/core/PreventScreenshot.js
app/core/SecureKeychain.js
app/core/TransactionTypes.js
app/core/Vault.js
```
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked issues 10815, 10818, 10816, and 10817, then inspect the listed files under app/core/. Track the conversion in chunks of five files, including deletion of app/core/DrawerStatusTracker.js as noted; done means the specified JavaScript files have been converted to TypeScript or removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100