MetaMask / MetaMask/metamask-mobile

Migrate TS version to fix compiler bug where Extract does not fully compute unions

Open
#10,364 0 comments 0 reactions 1 assignee Claimed by @Jonathansoufer View on GitHub
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

There is a typescript compiler bug where Extract does not fully compute unions, which is fixed in a later version

### Scenario

- GIVEN a typescript union.
- WHEN compiler reads typescript union code.
- THEN compiler does not fully compute unions.

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

Typescript compiler fully computing unions.

### Stakeholder review needed before the work gets merged

- [X] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.