MetaMask / MetaMask/metamask-mobile

Setup GitHub action that verifies new e2e tests are written with every new feature

Open
#10,118 0 comments 0 reactions 0 assignees View on GitHub
team-mobile-platform technical research
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

We want to have an automated check in place to prevent engineers from merging new features without adding new tests (unit, e2e, api, etc.). This check would encourage engineers to include new tests alongside new features proactively.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named in the issue, and its acceptance criteria are empty. First map the repository's existing GitHub Actions and test suites, then define how a feature change is identified and which test coverage is required. Done means the automated check reliably blocks or flags qualifying changes without tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, testing-qa
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.