MetaMask / MetaMask/metamask-extension

Balances rounding up are confusing, need UX improvement

Open
#9,932 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-balances needs-design type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

**Describe the bug**
I have `_._07089 ETH`. Metamask shows it as `_._071` which is more than I actually have. (numbers redacted for privacy).

**Steps to reproduce (REQUIRED)**
Steps to reproduce the behavior, libraries used with version number, and/or any setup information to easily reproduce:

1. Open the extension

**Expected behavior**
All balances should be rounded down, meaning it shows `_._070`.

**Screenshots**

Parts of the screenshots are blacked out to protect personal information. Important bits are highlighted in red.
![Frame 1](https://user-images.githubusercontent.com/17070569/99942908-b5865980-2d70-11eb-8e50-de481b869483.png)
![Frame 2](https://user-images.githubusercontent.com/17070569/99942913-b6b78680-2d70-11eb-88af-b3d2dac1d58a.png)

**Browser details (please complete the following information):**
- OS: MacOS Big Sur
- Hardware Wallet: n/a
- Browser: Issue reproduced on latest Chrome and Firefox
- MetaMask Version: 8.1.5

**Additional context (Error Messages, etc.)**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the balance display in the extension on Chrome or Firefox with a value that rounds upward. Trace the balance-formatting entry point and verify that displayed balances are rounded down; done means the shown value never exceeds the actual balance and the behavior is covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.