MetaMask / MetaMask/metamask-extension

Display on-chain failure reason on tx confirmation

Open
#9,419 2 comments 0 reactions 0 assignees View on GitHub
area-transactions needs-design team-confirmations-planning type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

We currently show a warning when a transaction is likely to run out of gas, but we could also show the error text related to any transaction failure.

Should adequately [security frame](https://roamresearch.com/#/app/capabul/page/7aWlNb1wi) that this error message is coming from an untrusted source: https://medium.com/metamask/phisher-watch-airdrop-scams-82eea95d9b2a

https://twitter.com/smpalladino/status/1305991209257775105?s=12

Contributor guide

Open the contributing guide

Research direction

Start by locating the transaction confirmation UI and the existing warning for transactions likely to run out of gas. Review the linked security guidance before deciding how an on-chain failure reason should be presented as untrusted content. Done means failed transactions display their error text without implying that it is trusted or safe.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.