MetaMask / MetaMask/metamask-extension

Save latest phishing-detect config list to disk on update

Open
#9,412 0 comments 1 reaction 0 assignees View on GitHub
type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

Currently if MetaMask is unable to reach the latest phishing-detect list, it falls back to its local copy of `eth-phishing-detect`, which can be old (since the core module is stable and rarely receives changes).

This means we fallback to some outdated phishing detection list, though. It would be better if the client would remember the latest "live" state it was aware of, and fell back to that first.

Related to issues like https://github.com/MetaMask/eth-phishing-detect/issues/4192

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Start by tracing how the extension updates and falls back to the eth-phishing-detect list, then identify where the live list can be persisted; done means the latest known live state is saved and preferred when the list cannot be reached.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.