MetaMask / MetaMask/metamask-extension
Phishing controller should be protocol-aware
Open
area-name-systems
type-enhancement
type-security
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
The phishing controller should expect `origin` rather than `hostname` strings, and we should different different phishing lists for different protocols.
For example:
- DNS-related, e.g. http/https
- ENS (when not effectively resolved through DNS)
- IPFS
And so on.
Contributor guide
Research direction
No files or tests are named. Start by locating the phishing controller and its handling of origin versus hostname, then clarify how phishing lists should differ for DNS-related protocols, ENS, and IPFS; done means protocol-aware origins and separate lists are supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100