MetaMask / MetaMask/metamask-extension

Make connected-status-indicator-popover styles more dynamic

Open
#8,332 0 comments 0 reactions 0 assignees View on GitHub
area-UI type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

With https://github.com/MetaMask/metamask-extension/pull/8293 we add a popover that points an arrow to the connected status indicator, and surrounds it with an element that looks like an opaque dark grey background with a clear oval around the indicator:

![Screenshot from 2020-04-09 11-01-01](https://user-images.githubusercontent.com/7499938/79219867-95cba200-7e2d-11ea-918f-38be69cf7dac.png)

The size of the clear oval and the position of the arrow are not dynamic based on the width or position of the connected status indicator. We can improve on that by either making it a tooltip and using a tooltip library, or using refs as was done in this (no longer used) commit: https://github.com/MetaMask/metamask-extension/commit/ade401d5d664e6fa1c87ece518abfb81d825b93f

Contributor guide

Open the contributing guide

Research direction

Start by reviewing pull request #8293, which introduced the connected-status-indicator popover, and commit ade401d5d664e6fa1c87ece518abfb81d825b93f for the earlier refs-based approach. Compare the current popover behavior with the screenshot and verify that the clear oval and arrow adapt to the indicator’s width and position.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.