MetaMask / MetaMask/metamask-extension

Cannot edit gas price when signing multiple transactions

Open
#7,651 4 comments 0 reactions 0 assignees View on GitHub
team-confirmations-planning type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

**Describe the bug**
If a dapp initiates multiple transactions, the first transaction's gas can be edited, however, the 2nd on are uneditable.

**To Reproduce**

1. Go to tokentrove.com
2. select an item, then click "buy multiple"
3. enter 2 or more
4. confirm the first transaction
5. on the 2nd transaction, try to edit the gas (you will see it revert to the originally suggested gas price)

**Expected behavior**
Allow users to edit gas on every transaction.

**Additional context**
reddit post: https://www.reddit.com/r/Metamask/comments/e6238q/gas_price_does_not_stay_set_when_signing_multiple/

Edit by danjm, July 25, 2023:

I am changing this from a bug to an enhancement. As per Thomas' comments below, this was actually a user looking for functionality we never supported: the ability to edit gas once for multiple open transactions.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the flow at tokentrove.com: initiate multiple transactions, confirm the first, and edit gas on the second. Trace the transaction confirmation and gas-editing entry points in the extension UI. Done means a user can edit gas for every transaction in a multi-transaction flow and the chosen value does not revert.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.