MetaMask / MetaMask/metamask-extension

Support CoolWalletS hardware wallet.

Open
#7,569 9 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-hardware area-integration T08-featureRequest
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

**What problem are you trying to solve?**
Support [CoolWalletS](https://www.coolwallet.io/) hardware wallet.
I have been putting some efforts on the integration and want to see if the integration seems okay to the team. Please let us know what you think, how can we improve or any other feedbacks are welcomed.

**Describe the solution you'd like**
We plan to release a [CoolWalletS Bridge](https://coolwallets-connect.herokuapp.com/) webpage like TrezorConnect, and use it as a bridge to establish Bluetooth connection and to communicate with the hardware wallet. If the wallet is empty or the user has not registered the web app to the card before, this page will help the user setup/register/reset.

**Additional context**
What we have so far:
* A [eth-coolwallets-keyring](https://github.com/antoncoding/eth-cws-keyring)
* A [fork of MetaMask](https://github.com/antoncoding/metamask-extension) wrapping the keying.
* continuous development on **CoolWalletS Bridge**

Some screenshots from what we already have:

### Connect to CoolWalletS

![](https://i.imgur.com/9NlxA52.png)
![](https://i.imgur.com/a5QBow3.png)
![](https://i.imgur.com/f7w6G4x.png)
![](https://i.imgur.com/tTCVu63.png)

### Signing Tx
![](https://i.imgur.com/wxZ6KKx.png)
![](https://i.imgur.com/qv0semO.png)
![](https://i.imgur.com/C4jGjad.png)

Our wallet also supports signing message and typedData, the screenshots look similar so I'll skip it.

Please let us know if you think this integration is feasible. Thanks a lot

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the proposed CoolWalletS Bridge, the eth-coolwallets-keyring, and the linked fork of the MetaMask extension. Compare the existing connection, transaction-signing, message-signing, and typedData flows with the extension's integration points. Done would require a decided, maintainable integration plan and team confirmation that the approach is feasible.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.