MetaMask / MetaMask/metamask-extension

IDEX unable to prevent users from submitting funds via unsupported hardware wallets on MetaMask

Open
#6,573 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-hardware area-integration needs-research type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

**Describe the bug**
IDEX does not work with hardware wallets. If someone deposits funds via Trezor or Ledger through MetaMask, those funds are locked in the contract, and cannot be traded or withdrawn.

**To Reproduce**
Steps to reproduce the behavior (do not _actually_ do this, you will lose funds!):
1. Go to IDEX
2. Click on Balances
3. Deposit ETH or any token via Ledger or Trezor connected through MetaMask
4. Attempt to trade those tokens, or withdraw them

**Expected behavior**
Either receive a message stating this is not yet supported, or add the ability to support it.

**Screenshots**
![image](https://user-images.githubusercontent.com/16330048/57255330-1af0e900-7019-11e9-93c4-caf6354cb259.png)

support case: 18940

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Balances deposit flow described in the reproduction steps, using MetaMask with a Ledger or Trezor only in a safe test environment. Trace how the flow handles deposits and subsequent trading or withdrawals, then determine whether unsupported hardware wallets should receive a warning or be supported; done means funds cannot be irrecoverably locked by this path.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.