MetaMask / MetaMask/metamask-extension

Create passthrough-keyring for Brave

Open
#4,860 0 comments 0 reactions 0 assignees View on GitHub
browser-brave INVALID-ISSUE-TEMPLATE type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

When running in Brave, should auto-detect a Geth instance running on `localhost:8545` with unlocked accounts.

- Should show any unlocked accounts as accounts in this passthrough keyring.
- Should allow signing with these accounts.

Stretch goals:

- Initialize account nicknames using RPC: `db_getString`, params: `['braveEthWallet', 'wallets']`. Will return data of form: `[{name: "Account 1", address: "0xabcdef…"}]`.

Contributor guide

Open the contributing guide

Research direction

No file or test is named. Start by locating the existing keyring implementations and the Brave/Geth RPC integration, then determine how localhost:8545 account discovery and signing fit together. Done means unlocked accounts appear in the passthrough keyring and can sign; nickname initialization is an optional stretch goal.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.