MetaMask / MetaMask/metamask-extension

[Bug]: Activity - `Swap tokens` grayed out on empty activity list

Open
#46,080 0 comments 0 reactions 1 assignee Claimed by @ameliejyc View on GitHub
feature-request regression-RC-13.48.0 Sev2-normal team-core-extension-ux type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

Whenever we select an account with funds but no activity, if we go to the Activity page, we can see the message `Swap your first token today.`
and the button `Swap tokens`. However, this button is disabled in some networks, making our suggestion pointless.

I'm unsure if that is due to not supporting Swaps on that selected network, however this is not the case for Robinhood, where we do support Swaps, but the button is grayed out.
Furthermore, whenever I'm on another network (ie Linea), clicking Swap, leads to an Ethereum Mainnet swap page, meaning, we are not constructing that swap based on the filtered network, which makes it pointless to gray out the button in some ocasions.

### Expected behavior
Unsure which route do we want to go. Few possibilities:
- Enable the Swap button always, and land into the Swap on Ethereum page always
- Enable Swap button only on supported networks, landing on the Swap on that specific network tokens
- Remove the suggestion when (if) that button is grayed out, as it is pointless

### Screenshots/Recordings

https://github.com/user-attachments/assets/89108b6e-d71b-473e-b820-197a93dd054f

### Steps to reproduce

1. Select an account with funds but without Activity in Arc
2. Click Activity
3. Filter by Arc network
4. See the message: `Swap your first token today.` but see how the Swap tokens button is disabled

### Error messages or log output

```shell

```

### Where was this bug found?

Internal release testing

### Version

13.48.0

### Build type

None

### Browser

Chrome

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.