MetaMask / MetaMask/metamask-extension

[Bug]: Signatures - `0x` address type fields in EIP-712 signatures are parsed as 0 ETH in the Signature screen

Open
#46,075 0 comments 0 reactions 0 assignees View on GitHub
regression-prod-13.46.1 Sev2-normal team-confirmations type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

`0x` address type fields in EIP-712 signatures are parsed as 0 ETH in the Signature screen

See how we are passing the `0x0000000000000000000000000000000000000000` address in the Recipient maker fee field, but that is displayed as 0 ETH in the Signature screen

https://github.com/MetaMask/test-dapp/blob/2252b59ca8a0d23a6186cc54731fcc9af29c5501/src/signatures/utils.js#L72

### Expected behavior

Display that field as an address as expected

### Screenshots/Recordings

Image

### Steps to reproduce

1. Connect to the test dapp
2. Trigger Blur Order signature
3. Open details
4. See recipient displayed as 0 ETH

### Error messages or log output

```shell

```

### Where was this bug found?

Live version (from official store)

### Version

13.46.1

### Build type

None

### Browser

Chrome

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the linked test-dapp source at src/signatures/utils.js#L72 and reproduce the Blur Order signature flow in the Signature screen. Trace how the recipient maker fee address is displayed in the signature details, and consider the work complete when the 0x address is shown as an address rather than 0 ETH.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.