MetaMask / MetaMask/metamask-extension

[Bug]: Cannot add Ledger account with passphrase when already added Ledger account without passphrase

Open
#45,684 2 comments 0 reactions 0 assignees View on GitHub
cs-triaged external-contributor regression-prod-* Sev3-low team-hardware-wallets
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

When adding a Ledger account without passphrase (choosing the first address on the list) and then trying to add a Ledger account with passphrase (choosing the first address on the list) it doesn't add the latter account.
It seems to happen when the address for both accounts appear in the same location on the address selection list (for example both are the first address on the list).

### Expected behavior

Add both accounts to MetaMask

### Screenshots/Recordings

_No response_

### Steps to reproduce

1. Set up the Ledger device (enter seed)
2. Connect Ledger via MetaMask and add the first address on the list (account type: BIP44 Standard)
3. Enter some passphrase in the Ledger device
4. Connect Ledger via MetaMask and add the first address on the list (account type: BIP44 Standard)

Behavior: It shows the correct address on the address selection list. When choosing it and trying to add it, it doesn't add it

### Error messages or log output

```shell
No error message
```

### Where was this bug found?

Live version (from official store)

### Version

13.44

### Build type

None

### Browser

Chrome

### Operating system

Windows

### Hardware wallet

Ledger

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Reproduce the Ledger flow by adding the first BIP44 Standard address without a passphrase, then adding the first address after entering a passphrase. Trace the address-selection and account-addition flow for the duplicate list position; done means both distinct Ledger accounts are added successfully without an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.