MetaMask / MetaMask/metamask-extension

[Bug]: `includeInStateLogs: false` property is ignored

Open
#44,071 0 comments 0 reactions 0 assignees View on GitHub
area-privacy team-extension-platform type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

`includeInStateLogs: false` property is ignored, causing those properties to do appear in the state logs file.

See example:

```
networkConnectionBanner: {
includeInStateLogs: false,
persist: false,
includeInDebugSnapshot: false,
usedInUi: true,
},
```

and download state logs and look for the property

### Expected behavior

_No response_

### Screenshots/Recordings

Image

### Steps to reproduce

1. Go to Privacy Settings
2. Download state logs
3. Look for this property `networkConnectionBanner`
4. See its there and with values, however this should be ignored

### Error messages or log output

```shell

```

### Where was this bug found?

Internal release testing

### Version

main (but unsure when the bug was introduced)

### Build type

None

### Browser

Chrome

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start in Privacy Settings by tracing the state-log download path and how the `includeInStateLogs` property is handled. Reproduce the issue with `networkConnectionBanner`, inspect the generated state logs, and confirm that properties marked false are omitted when the fix is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.