MetaMask / MetaMask/metamask-extension

[Bug]: Confirmations - Ticking and unticking Added Protection stops working intermittently

Open
#43,023 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ai-eligible regression-RC-13.33.0 Sev2-normal team-confirmations type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

Describe the bug

Ticking and unticking Added protection stops working intermittently. I've experienced this 2 times already, after unticking, I cannot tick the box back, and it remains unticket.

Expected behavior

Ticking and unticking the box should enable and disable the feature

Screenshots/Recordings

https://github.com/user-attachments/assets/3de366d9-a1dd-42e3-9f9b-0af2d801d9df

Steps to reproduce
  1. Go to test dapp
  2. Connect
  3. Trigger a Send Call with these 2 tx:
  • 1st one the predefault one
  • 2nd one this
    to: 0x6B175474E89094C44Da98b954EedeAC495271d0F
    data: 0x095ea7b3000000000000000000000000d67b0c05bcea4eecf3bae87a7d7e00ad10fc047a0000000000000000000000000000000000000000000000000000000000000002
    value: 0x0
  • Now tick and untick the box several times --> at some point it stops working
Error messages or log output

Where was this bug found?

Internal release testing

Version

13.33.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the test dapp using the two described transactions, then inspect the Added protection confirmation UI and its toggle state. Done means the box can be ticked and unticked repeatedly, reliably enabling and disabling the feature in Chrome on Linux.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.