MetaMask / MetaMask/metamask-extension
MetaMask policy-bot stays pending on approved, mergeable PR
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### What is this about?
This is a repository workflow / bot issue, not a code-review request.
An approved and mergeable PR can remain stuck because `policy-bot` and `policy-bot: main` stay pending even when the other visible checks have already passed.
### Scenario
Current example:
1. PR: https://github.com/MetaMask/metamask-extension/pull/42710
2. State: open, non-draft, mergeable
3. Review state: approved
4. Other visible checks: passing
5. Blocking state: `policy-bot` and `policy-bot: main` remain pending
### Design
I am raising this as an infra / workflow issue so it can be handled separately from the code review on that PR.
### Technical Details
The currently visible blocking condition is not a failed code check. It is a pair of pending policy checks that appear to prevent the PR from progressing:
1. `policy-bot`
2. `policy-bot: main`
### Threat Modeling Framework
This is not a security vulnerability report. It is a workflow reliability problem that can strand approved PRs behind permanently pending repository checks.
### Acceptance Criteria
A maintainer can clarify one of the following:
1. this is expected behavior and the PR is missing some required maintainer-side action, label, or branch condition
2. this is an infra / workflow problem that should be fixed so approved PRs do not remain blocked by permanently pending policy checks
### References
1. Example PR: https://github.com/MetaMask/metamask-extension/pull/42710
2. This issue was opened after confirming that the PR was still approved, mergeable, non-draft, and blocked only by pending `policy-bot` checks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use PR #42710 as the reproduction case and inspect the `policy-bot` and `policy-bot: main` checks alongside the repository workflow configuration. Done means either the required maintainer-side condition is identified or approved, mergeable PRs no longer remain blocked by permanently pending policy checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd, devops, infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100