MetaMask / MetaMask/metamask-extension

[Bug]: Batch Transaction - Edit approval amount in batch transaction leaves wallet in a loop without able to edit again

Open
#42,532 0 comments 0 reactions 0 assignees View on GitHub
regression-prod-13.28.0 Sev2-normal team-confirmations type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

Edit approval amount to a smaller amount (making the tx to fail) in batch transaction leaves wallet in a loop, where we see `Transaction is likely to fail` appearing then the batch tx details appearing, but you are not able to edit that again

### Expected behavior

Maybe we should be able to edit that again? or if not, avoid somehow the loop of display between the 2 components?
cc @bschorchit

### Screenshots/Recordings

https://github.com/user-attachments/assets/cdd041d7-2e64-4129-9567-5ab7e2091430

### Steps to reproduce

1. Go to the test dapp
2. Connect with Mainnet
3. Click Execute Batch Swap
4. Edit one of the Approve transactions to a smaller amount: 0.001
5. See loop with Transaction is likely to fail appearing then the batch tx details appearing, but you are not able to edit again

### Error messages or log output

```shell

```

### Where was this bug found?

Live version (from official store)

### Version

13.28.0

### Build type

None

### Browser

Chrome

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in the test dapp with Mainnet and the batch swap flow described in the steps. Trace the transition between the “Transaction is likely to fail” view and the batch transaction details after editing an approval amount to 0.001. Done means the flow no longer loops and its edit behavior matches the agreed expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.