MetaMask / MetaMask/metamask-extension

[Bug]: [Ledger] Infinite loader is presented after a failed swap

Open
#40,880 1 comment 0 reactions 2 assignees Claimed by @matthewwalsh0 View on GitHub
regression-prod-13.20.0 Sev3-low team-confirmations type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

Using Ledger wallet, if the user rejects the signing, infinite loader is presented.

**Expected result:**
Chrome notification should show that the signing has been rejected by the user and after the failed swap the user should be taken to the main MM screen.

**Actual result:**
Chrome notification doesn't appear. Infinite loader is presented with message "Confirm with you hardware wallet", even though the user already cancel the transaction and the swap has failed.

**Environment:**

Device: MacBook Pro M4 ; macOS Tahoe 26.3.1
Chrome version: 145
MM prod 13.20.0

**Hardware wallet:** Ledger Nano Gen5

### Expected behavior

_No response_

### Screenshots/Recordings

https://github.com/user-attachments/assets/7cd3600e-d1c0-40ea-82ab-2469406d66c4

### Steps to reproduce

- connect MM with Leder
- start with the swap scenario
- click "Get signature"
- in Ledger, reject the signing
- notice that Chrome notification doesn't appear
- notice the infinite loader even though the transaction failed

### Error messages or log output

```shell

```

### Where was this bug found?

Live version (from official store)

### Version

13.20.0

### Build type

None

### Browser

Chrome

### Operating system

MacOS

### Hardware wallet

Ledger

### Additional context

_No response_

### Severity

sev3

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.