MetaMask / MetaMask/metamask-extension

[Bug]: Ledger Nano S - setApprovalForAll (true/false) not working anymore

Open
#40,274 0 comments 0 reactions 0 assignees View on GitHub
regression-RC-13.20.0 Sev2-normal team-hardware-wallets type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

Whenever I trigger the setApprovalForAll method, and Confirm in MetaMask, I get the following background error `"HardwareWalletError [Unknown:99999]: EthAppNftNotSupported\n at new o (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-1.js:1:210934)\n ` and I am not able to confirm the contract interaction

### Expected behavior

_No response_

### Screenshots/Recordings

https://github.com/user-attachments/assets/832ab9b7-24af-4185-aafd-928d4a09e06f

### Steps to reproduce

1. Go to the test dapp https://metamask.github.io/test-dapp/
2. Connect a Ledger Account (using Nano S)
3. Deploy an ERC721 (can be in Sepolia)
4. Confirm
5. Click Set Approval For All
6. Confirm in MM
7. See background error
8. Click Revoke
9. Confirm in MM
10. See background error

### Error messages or log output

```shell

```

### Where was this bug found?

Internal release testing

### Version

13.20.0

### Build type

None

### Browser

Chrome

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the failure in the MetaMask test dapp using a Ledger Nano S and the setApprovalForAll and Revoke actions. Check the resulting EthAppNftNotSupported error in the extension background logs. Done means both ERC721 approval actions can be confirmed successfully on the reported setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.