MetaMask / MetaMask/metamask-extension

[Bug]: Settings - Whenever disabling Basic Functionality some settings are disabled but some are kept enabled (despite being disabled)

Open
#40,081 0 comments 0 reactions 0 assignees View on GitHub
needs-triage regression-prod-13.16.0 team-core-extension-ux type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

There's a miss-alignemnt on how settings behave (are changed) whenever Basic Functionality is disabled.
Some settings are disabled, but some other keep the toggle enabled despite being disabled in reality (ie Security Alerts, DEcode Smart Contracts, Estimate balance changes).

Extra note: whenever Basic functionality is enabled, all toggles are re-enabled except Metametrics -> that is expected for Legal reasons.

### Expected behavior

We should align the behaviour of the toggles --> all 3rd party toggles should be automatically disabled if Basic Func is disabled?

### Screenshots/Recordings

https://github.com/user-attachments/assets/d7cc3d78-735f-440f-8463-9c04524a3ffc

### Steps to reproduce

1. Go to Security Settings
2. Disable Basic Functionality
3. See some toggles which use 3rd party requests, remain enabled (despite being disabled in reality)

### Error messages or log output

```shell

```

### Where was this bug found?

Live version (from official store)

### Version

13.16.0

### Build type

None

### Browser

Chrome

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start in the Security Settings flow and reproduce the behavior by disabling Basic Functionality, checking Security Alerts, Decode Smart Contracts, and Estimate balance changes. Trace how these toggles reflect the disabled state and verify that the affected third-party settings consistently show the expected state, while Metametrics retains its documented exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.