MetaMask / MetaMask/metamask-extension
[State Sync Redesign 1.2] Delete dead EventEmitter events (`lock`, `unlock`)
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
`MetamaskController.emit('lock')` and `emit('unlock')` have zero listeners. Delete the emit calls.
## Steps
1. Delete `this.emit('lock')` call
2. Delete `this.emit('unlock')` call
3. Verify no listeners registered for either event
## Files
- `app/scripts/metamask-controller.js`
## Risk
None — dead code.
## Dependencies
None
## Context
Part of [State Sync Redesign — Epic 1: Transport optimization].
Contributor guide
Research direction
Start in app/scripts/metamask-controller.js and inspect the lock and unlock emit calls. Search the repository to verify that neither event has listeners, then confirm both calls are gone and the existing checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100