MetaMask / MetaMask/metamask-extension
[State Sync Redesign 1.1] Remove `publicConfigStore`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
Remove the `publicConfigStore` ObservableStore instance and `createPublicConfigStore()` method from MetamaskController. Already marked `TODO:LegacyProvider: Delete`.
## Steps
1. Remove `publicConfigStore` creation (line 1413, 2257-2285)
2. Remove `setupPublicConfig` method (line 7973-7983)
3. Remove the `this.on('update', updatePublicConfigStore)` listener
4. Verify no dapp-facing regression (legacy inpage provider)
## Files
- `app/scripts/metamask-controller.js`
## Risk
Low — already tagged for removal. Verify with E2E tests.
## Dependencies
None
## Context
Part of [State Sync Redesign — Epic 1: Transport optimization].
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in app/scripts/metamask-controller.js and inspect the marked TODO:LegacyProvider sections around publicConfigStore creation, setupPublicConfig, and the update listener. Remove the obsolete instance, method, and listener, then run the relevant E2E tests to verify there is no dapp-facing legacy inpage provider regression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100