MetaMask / MetaMask/metamask-extension
[Bug]: Deeplinks - Clicking any Product Banner from within the wallet opens a new MM extension tab everytime
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### Describe the bug
Clicking any Product Banner from within the wallet opens a new MM extension tab everytime
For example, if I click on the Shield one, instead of taking me to Settings in the existing MetaMask page, it opens a new tab and takes me to Settings there. I imagine this is because we are using Deeplinks and how they work, though it might be a bit strange opening new tabs while you trigger an action from within the wallet
### Expected behavior
If we are triggering a deeplink from inside the wallet, we shouldn't open a new tab rather keep the current MM tab?
### Screenshots/Recordings
https://github.com/user-attachments/assets/0767213c-a1a8-4f42-bf0e-a4556f1b523a
### Steps to reproduce
1. Start a fresh wallet
2. Click a deeplink (perps)
3. See a new tab is open
### Error messages or log output
```shell
```
### Where was this bug found?
Live version (from official store)
### Version
13.15.0
### Build type
None
### Browser
Chrome
### Operating system
MacOS
### Hardware wallet
_No response_
### Additional context
_No response_
### Severity
_No response_
Contributor guide
Research direction
Start by reproducing the issue in the Chrome extension using a fresh wallet and the Perps or Shield product banner. Trace how the deeplink is handled when triggered inside the existing wallet tab. Done means the action opens Settings in the current MetaMask tab without creating another extension tab.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100