MetaMask / MetaMask/metamask-extension
[Bug]: 0xName Resolver Snap no longer works in MetaMask Extension due to domain validation step
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### Describe the bug
We received this report from an external party:
> 0xNAME Resolver Snap, listed on the Snap Directory, is simply resolving 0xNAMEs to addresses and was working perfectly since it was published until recently. We noticed that with the most recent MetaMask browser extension update (13.11.2) 0xNAMEs are not being resolved in the "send flow" anymore, although the Resolver Snap is installed and nothing changed on the Snap side. I attached a screenshot from my MetaMask Firefox browser extension, and here is the brief description of the issue: now when I write a name (for ex. yulia@beast) while sending anything, instead of resolving the name to the address as usually, I see the error message "invalid address".
We tested and confirmed the issue. The Snap supports names like `alice@ethereum`. The send flow attempts a validation check before calling any resolver Snaps [here](https://github.com/MetaMask/metamask-extension/blob/main/ui/pages/confirmations/hooks/send/useNameValidation.ts#L18). Due to this, any name that does not look like a domain name will never work. This breaks multiple resolver Snaps, including 0xName and Clusters.
### Expected behavior
When the 0xNAME Resolver Snap is installed and entering `yulia@beast` in the send flow on Ethereum, it resolves to an address.
### Screenshots/Recordings
_No response_
### Steps to reproduce
1. Install 0xNAME Resolver Snap https://snaps.metamask.io/snap/npm/0xname-resolver-snap/
2. Open send flow
3. Enter `yulia@beast`
4. Observe the error
### Error messages or log output
```shell
```
### Where was this bug found?
Live version (from official store)
### Version
13.11.2, 13.13.2
### Build type
None
### Browser
Firefox
### Operating system
MacOS
### Hardware wallet
_No response_
### Additional context
_No response_
### Severity
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.