MetaMask / MetaMask/metamask-extension
[Bug]: Extra network confirmation from popular network list still triggers
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### Describe the bug
Recently, a change was made where adding a network from the popular list would just auto-add instead of providing the `Are you sure` confirmation.
However, this `Are you sure` still triggers on the banners. `Jump into Monad` is an example.
### Expected behavior
It should auto add the network
### Screenshots/Recordings
_No response_
### Steps to reproduce
1. Open fresh MM
2. Add SEI or another popular network (not monad)
3. Click Monad banner
4. See additional confirmation to add network
### Error messages or log output
```shell
```
### Where was this bug found?
Internal release testing
### Version
13.13
### Build type
None
### Browser
Chrome
### Operating system
MacOS
### Hardware wallet
_No response_
### Additional context
_No response_
### Severity
_No response_
Contributor guide
Research direction
Reproduce the issue in the MetaMask extension using the listed steps: add SEI, then click the Monad banner and observe the confirmation. Trace the popular-network and banner network-add flow; done means clicking the banner auto-adds the network without an additional confirmation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100