MetaMask / MetaMask/metamask-extension
Error: KeyringController - The operation cannot be completed while the controller is locked.
Open
Nobody has claimed this yet.
area-sentry
external-contributor
INVALID-ISSUE-TEMPLATE
team-core-platform
type-bug
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
Sentry Issue: METAMASK-XRAW
Error: KeyringController - The operation cannot be completed while the controller is locked.
at MetamaskController.setLocked (app/scripts/metamask-controller.js:8365:36)
at <object>.controller.onInactiveTimeout (app/scripts/controller-init/app-state-controller-init.ts:24:30)
at <anonymous> (app/scripts/controllers/app-state-controller.ts:1094:36)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with app/scripts/metamask-controller.js around setLocked, then inspect app/scripts/controller-init/app-state-controller-init.ts and app/scripts/controllers/app-state-controller.ts at the reported callbacks. Trace why the inactivity handler can call setLocked while KeyringController is already locked. Done means the reported error no longer occurs on this path, with a regression test if the relevant test location is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100