MetaMask / MetaMask/metamask-extension

Treat burn address as invalid when added as contact

Open
#37,544 2 comments 0 reactions 0 assignees View on GitHub
area-addressBook external-contributor Sev3-low team-core-extension-ux
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

When adding `0x000000000000000000000000000000000000dEaD` as a contact it is currently not flagged as invalid.

Validation for this address already exists within the Send flow `ui/pages/confirmations/utils/sendValidations.ts`. Contacts relies on a legacy send util that does not define the burnaddress. `shared/modules/hexstring-utils.ts`

Update Contact address validation to use the sendValidation.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with shared/modules/hexstring-utils.ts and compare its legacy contact validation with ui/pages/confirmations/utils/sendValidations.ts. Trace the contact address validation path, update it to use the send validation, and verify that adding 0x000000000000000000000000000000000000dEaD as a contact is rejected.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.